On 01/05/2018 10:46 AM, Ananyev, Konstantin wrote:
-----Original Message----- From: dev [mailto:[email protected]] On Behalf Of Declan Doherty Sent: Monday, April 30, 2018 4:33 PM To: [email protected] Cc: Doherty, Declan <[email protected]> Subject: [dpdk-dev] [PATCH 2/3] net/ixgbe: initialise nb_representor_ports value Initialise rte_ethdev_args nb_representor_ports to zero to handle the case where no devargs are passed to the IXGBE PF on device probe, so that there is no invalid attempts to create representor ports. Coverity Issue: 277231 Fixes: cf80ba6e2038 ("net/ixgbe: add support for representor ports") Signed-off-by: Declan Doherty <[email protected]> --- drivers/net/ixgbe/ixgbe_ethdev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c index 0ccf55dc8..283dd7e49 100644 --- a/drivers/net/ixgbe/ixgbe_ethdev.c +++ b/drivers/net/ixgbe/ixgbe_ethdev.c @@ -1725,8 +1725,7 @@ eth_ixgbe_pci_probe(struct rte_pci_driver *pci_drv __rte_unused, struct rte_pci_device *pci_dev) { char name[RTE_ETH_NAME_MAX_LEN]; - - struct rte_eth_devargs eth_da; + struct rte_eth_devargs eth_da = { .nb_representor_ports = 0 }; int i, retval; if (pci_dev->device.devargs) {Might be a bit better: If (pci_dev->device.devargs) { rte_eth_devargs_parse(...);...} else memset(ð_da, 0, sizeof(eth_da)); to be more consistent. BTW, I think rte_eth_devargs_parse() need to add formal check for input parameters. Konstantin
Ok, thanks Konstantin, that makes sense, we're working on cleaning up rte_eth_devargs_parse() to align with kvargs so I'll make sure to add those checks.
-- 2.14.3
