chrismattmann commented on a change in pull request #129: Replaced
Processwrapper indexing method with SolrIndexer
URL: https://github.com/apache/drat/pull/129#discussion_r189311048
##########
File path: proteus/src/main/java/backend/ProcessDratWrapper.java
##########
@@ -175,7 +190,12 @@ public void go() throws Exception {
// before go, always reset
this.reset();
this.crawl();
+
+ LOG.info("Indexing starts");
Review comment:
Eventually including this for all of the DRAT commands is likely a good
idea. Furthermore, since this will get lost in the Tomcat logs for Proteus
amongst all the other output, you may want to precede it with some identifier
e.g.,
```java
long timeInLong = System.currentTimeMilis();
long timeDiff = -1L;
ZonedDateTime zdt = ZonedDateTime.ofInstant(Instant.ofEpochMilli(timeInLong),
ZoneId.systemDefault()); //
TODO: make this a function
LOG.info("ProcessDratWrapper: DRAT Go: Indexing starts at time {} ",
zdt.format(DateTimeFormatter.ISO_OFFSET_DATE_TIME));
this.index();
long indexEndTime = System.currentTimeMilis();
timeDiff = timeInLong - indexEndTime;
timeInLong = System.currentTimeMilis();
zdt = ZonedDateTime.ofInstant(Instant.ofEpochMilli(timeInLong),
ZoneId.systemDefault());
LOG.info("ProcessDratWrapper: DRAT Go: Indexing completes at time {} with
duration {}", zdt.format(DateTimeFormatter.ISO_OFFSET_DATE_TIME),
DurationFormatUtils.formatDurationISO(timeDiff));
```
See:
https://commons.apache.org/proper/commons-lang/javadocs/api-2.6/org/apache/commons/lang/time/DurationFormatUtils.html
and
https://stackoverflow.com/questions/26737026/java-long-time-to-iso-8601-string-format
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
