The patches have passed all unit tests on Both Windows and Linux and also the functional tests. I will commit them to both 0.7.0 and master branch shortly.
Thanks for the review! On Wed, Dec 17, 2014 at 4:41 PM, Jason Altekruse <altekruseja...@gmail.com> wrote: > > They all look good to me, added a +1 to each. Do you want to test/commit > them or would you like me to do it? > > On Wed, Dec 17, 2014 at 4:27 PM, Aditya <adityakish...@gmail.com> wrote: >> >> Can I please get these (small) patches reviewed. >> >> On Wed, Dec 17, 2014 at 6:42 AM, Aditya <adityakish...@gmail.com> wrote: >> > >> > https://issues.apache.org/jira/browse/DRILL-1878 >> > https://issues.apache.org/jira/browse/DRILL-1879 >> > https://issues.apache.org/jira/browse/DRILL-1881 >> > >> > Patches are attached to JIRAs and also pushed to my fork @ >> > https://github.com/adityakishore/drill/commits/0.7.0-fixes >> > >> > All unit tests pass on both Windows and Linux. >> > >> > On Tue, Dec 16, 2014 at 5:27 PM, Jacques Nadeau <jacq...@apache.org> >> > wrote: >> >> >> >> Sounds good. That sinks this release. Let's see if we can spin >> another >> >> soon. >> >> >> >> thanks! >> >> >> >> On Tue, Dec 16, 2014 at 4:07 PM, Aditya <adityakish...@gmail.com> >> wrote: >> >>> >> >>> -1 (binding) >> >>> >> >>> I ran into failures while >> >>> >> >>> 1) Running Drill unit tests on Windows, and >> >>> 2) Starting Drillbit on Windows in distributed mode. >> >>> >> >>> So I am -1 on this. >> >>> >> >>> Will create JIRAs for individual issues and put patches in a few >> hours. >> >>> >> >>> On Tue, Dec 16, 2014 at 9:45 AM, Norris Lee <norr...@simba.com> >> wrote: >> >>> > >> >>> > +1 >> >>> > >> >>> > - Built from source >> >>> > - Queried against Hive, HBase, CSV, JSON, Parquet files/tables >> >>> > >> >>> > Norris >> >>> > >> >>> > -----Original Message----- >> >>> > From: Neeraja Rentachintala [mailto:nrentachint...@maprtech.com] >> >>> > Sent: Tuesday, December 16, 2014 6:34 AM >> >>> > To: dev@drill.apache.org >> >>> > Subject: Re: [VOTE] Release Apache Drill 0.7.0 >> >>> > >> >>> > +1(non-binding) >> >>> > >> >>> > On Tue, Dec 16, 2014 at 12:15 AM, Mehdi Chitforoosh < >> >>> > mehdichitforo...@gmail.com> wrote: >> >>> > > >> >>> > > +1 >> >>> > > >> >>> > > On Tue, Dec 16, 2014 at 10:14 AM, Yash Sharma <yash...@gmail.com> >> >>> wrote: >> >>> > > > >> >>> > > > +1 >> >>> > > > >> >>> > > > - Source and binaries present >> >>> > > > - Source and Binaries contain README, NOTICE, LICENSE Files. >> >>> > > > - Source contains INSTALL.md >> >>> > > > - Verified Checksums for src and binaries >> >>> > > > - Able to launch drill from binary distribution (Embeded mode). >> >>> > > > - Able to build from source >> >>> > > > - Able to fire sample queries on sqlline >> >>> > > > >> >>> > > > On Mon, Dec 15, 2014 at 11:56 PM, Tomer Shiran < >> tshi...@gmail.com> >> >>> > > wrote: >> >>> > > > > >> >>> > > > > +1 >> >>> > > > > >> >>> > > > > On Mon, Dec 15, 2014 at 9:39 AM, Jacques Nadeau >> >>> > > > > <jacq...@apache.org> >> >>> > > > > wrote: >> >>> > > > > > >> >>> > > > > > Good morning, >> >>> > > > > > >> >>> > > > > > I would like to propose the release of Apache Drill, version >> >>> 0.7.0. >> >>> > > > > > >> >>> > > > > > This release includes 223 resolved JIRAs [1]. >> >>> > > > > > >> >>> > > > > > The artifacts are hosted at [2]. >> >>> > > > > > >> >>> > > > > > The vote will be open for 72 hours, ending 10 AM Pacific, >> >>> > > > > > December >> >>> > > 18, >> >>> > > > > > 2014. >> >>> > > > > > >> >>> > > > > > [ ] +1 >> >>> > > > > > [ ] +0 >> >>> > > > > > [ ] -1 >> >>> > > > > > >> >>> > > > > > >> >>> > > > > > Thank you, >> >>> > > > > > Jacques >> >>> > > > > > >> >>> > > > > > [1] >> >>> > > > > > >> >>> > > > > > >> >>> > > > > >> >>> > > > >> >>> > > >> >>> >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12313 >> >>> > > 820&version=12327473 >> >>> > > > > > [2] >> http://people.apache.org/~jacques/apache-drill-0.7.0.rc0/ >> >>> > > > > > >> >>> > > > > >> >>> > > > >> >>> > > >> >>> > > >> >>> > > -- >> >>> > > Mehdi Chitforoosh >> >>> > > >> >>> > >> >>> >> >> >> >
