----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24470/#review72904 -----------------------------------------------------------
Ship it! Ship It! - Parth Chandra On Feb. 16, 2015, 11:49 p.m., Xiao Meng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24470/ > ----------------------------------------------------------- > > (Updated Feb. 16, 2015, 11:49 p.m.) > > > Review request for drill, Alexander zarei and Parth Chandra. > > > Bugs: DRILL-1219 > https://issues.apache.org/jira/browse/DRILL-1219 > > > Repository: drill-git > > > Description > ------- > > Socket cancel operation does not work for 32-bit windows platform. Use > shutdown insted. > > > Diffs > ----- > > contrib/native/client/src/clientlib/drillClientImpl.hpp bd33317 > contrib/native/client/src/clientlib/drillClientImpl.cpp 40bd81e > contrib/native/client/src/include/drill/common.hpp 824d670 > > Diff: https://reviews.apache.org/r/24470/diff/ > > > Testing > ------- > > Tested with > > ``` > querySubmitter query="SELECT * FROM `hive43`.`default`.`orders` limit > 5000;SELECT * from INFORMATION_SCHEMA.SCHEMATA" type=sql > connectStr=local=192.168.39.44:31010 api=async logLevel=fatal > > plus_changes_fata.txt > ``` > > And the results were compared between 64 bit master branch, 32 bit master > branch (which fails and this patch is to fix it), 64 bit master branch plus > this patch. > > > Thanks, > > Xiao Meng > >
