> On Feb. 19, 2015, 3:30 a.m., Jacques Nadeau wrote: > > This isn't legal unless we know that the distribution keys were hashed the > > same way. Our thinking is that we should make sure that all numeric values > > hash the same way. For example, all convert to double and then are hashed. > > We need to evaluate the performance impact. When that isn't possible, we > > should throw a run time schema change exception and require the user to > > express the query with an explicit cast. Otherwise we'll return wrong > > result.
Good point..I thought this issue was a follow-up to an older bug DRILL-1125 which was fixed in 0.6. True, the implicit cast join will work only if the data is co-located or for broadcast joins. - Aman ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31160/#review73080 ----------------------------------------------------------- On Feb. 19, 2015, 2:23 a.m., Mehant Baid wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31160/ > ----------------------------------------------------------- > > (Updated Feb. 19, 2015, 2:23 a.m.) > > > Review request for drill and Aman Sinha. > > > Repository: drill-git > > > Description > ------- > > If the return type of the two expressions in the join condition are of > different types then we need to inject a cast on one of the sides for > comparison functions to work as expected > > > Diffs > ----- > > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/common/ChainedHashTable.java > ea19645 > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/JoinUtils.java > 04f3bbe > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/MergeJoinBatch.java > 257b93e > exec/java-exec/src/test/java/org/apache/drill/TestExampleQueries.java > 55fb59f > exec/java-exec/src/test/resources/parquetinput/department_decimal.parquet > PRE-CREATION > exec/java-exec/src/test/resources/parquetinput/employee_decimal.parquet > PRE-CREATION > > Diff: https://reviews.apache.org/r/31160/diff/ > > > Testing > ------- > > Added unit tests with hash join and merge join > > > Thanks, > > Mehant Baid > >
