> On Feb. 23, 2015, 5:44 p.m., Jinfeng Ni wrote: > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/visitor/InsertLocalExchangeVisitor.java, > > line 112 > > <https://reviews.apache.org/r/30965/diff/2/?file=871428#file871428line112> > > > > MuxExchange has Project as its child. So, MuxExchange will have same > > traits as Project (addColumnprojectPrel), in stead of its parent (prel).
Will definitely fix it - thank you for pointing out > On Feb. 23, 2015, 5:44 p.m., Jinfeng Ni wrote: > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/visitor/InsertLocalExchangeVisitor.java, > > line 127 > > <https://reviews.apache.org/r/30965/diff/2/?file=871428#file871428line127> > > > > I'm not fully clear about the motification of inserting the hash > > expression into Project. But here if we remove the compuated hash > > expression, does it mean that the down stream operator will not be able to > > refer to this computed value, and have to re-compute? The problem is that if we have HashJoin later on it is not aware of additional column and it will be failing, so after discussion with Jacques we decided to add Project before HashExchage and remove it after - so to thw world outside of Mux/HashExchange/Demux it will look as Project was never inserted - Yuliya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30965/#review73732 ----------------------------------------------------------- On Feb. 23, 2015, 4:09 p.m., Yuliya Feldman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30965/ > ----------------------------------------------------------- > > (Updated Feb. 23, 2015, 4:09 p.m.) > > > Review request for drill, Jacques Nadeau, Jinfeng Ni, Steven Phillips, and > Venki Korukanti. > > > Bugs: DRILL-2209 > https://issues.apache.org/jira/browse/DRILL-2209 > > > Repository: drill-git > > > Description > ------- > > Insert Project operator to add new column "EXPRHASH" with hash expression for > fields that are used for HashToRandomExchange > Remove Project operator after HashRandomExchange (or Demux) since it will > create problems to fields ordering in HashJoin. > > Tight this to MuxExchange - so if MuxExchange is enabled, Project is inserted. > > > Diffs > ----- > > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/HashToRandomExchangePrel.java > 372c75d > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/visitor/InsertLocalExchangeVisitor.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/30965/diff/ > > > Testing > ------- > > Need to add Unit Tests. tested live, run Functional and TPCH tests > > > Thanks, > > Yuliya Feldman > >
