----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30313/#review74406 -----------------------------------------------------------
contrib/storage-mongo/src/main/java/org/apache/drill/exec/store/mongo/MongoRecordReader.java <https://reviews.apache.org/r/30313/#comment120980> This does not seem quite right to me. What if multiple writes fail? Also note that this will change the order of records being written into vectors. contrib/storage-mongo/src/main/java/org/apache/drill/exec/store/mongo/MongoRecordReader.java <https://reviews.apache.org/r/30313/#comment120983> DRILL-1960 handles auto-reallocation of buffers. I don't think we will ever hit to this check due to out of memory issues. We should remove this. - Hanifi Gunes On Jan. 27, 2015, 10:27 a.m., Kamesh B wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30313/ > ----------------------------------------------------------- > > (Updated Jan. 27, 2015, 10:27 a.m.) > > > Review request for drill, Jacques Nadeau and Jinfeng Ni. > > > Repository: drill-git > > > Description > ------- > > Fixing Mongo join issue when * is selected. > > > Diffs > ----- > > > contrib/storage-mongo/src/main/java/org/apache/drill/exec/store/mongo/MongoRecordReader.java > 4b7360057e9d95fb0176b035469bca02128a0b34 > > Diff: https://reviews.apache.org/r/30313/diff/ > > > Testing > ------- > > Tested the patch by selecting * in join operation. It is working fine. This > patch also fixes some of issues caused by earlier commits. > > > Thanks, > > Kamesh B > >
