-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31688/
-----------------------------------------------------------
Review request for drill and Jacques Nadeau.
Bugs: DRILL-1385
https://issues.apache.org/jira/browse/DRILL-1385
Repository: drill-git
Description
-------
Cleaned up option handling. This includes using finals, making member variab
private whenever possible, and some formatting.
- fixed a bug in the string formatting for the double range validator
- OptionValidator, OptionValue, and their implementations now conspire not t
allow the creation of malformed options because the OptionType has been ad
to validator calls to handle OptionValues that are created on demand.
Testing also included DRILL-1385.2-2-core.patch.txt, which must also be applied
(after this patch) if this is.
Diffs
-----
exec/java-exec/src/main/java/org/apache/drill/exec/server/options/DrillConfigIterator.java
e4b03d3
exec/java-exec/src/main/java/org/apache/drill/exec/server/options/FallbackOptionManager.java
f515f8e
exec/java-exec/src/main/java/org/apache/drill/exec/server/options/OptionManager.java
83af7db
exec/java-exec/src/main/java/org/apache/drill/exec/server/options/OptionValidator.java
5b90ba5
exec/java-exec/src/main/java/org/apache/drill/exec/server/options/OptionValue.java
bfcbeca
exec/java-exec/src/main/java/org/apache/drill/exec/server/options/SystemOptionManager.java
3d3e96f
exec/java-exec/src/main/java/org/apache/drill/exec/server/options/TypeValidators.java
e53fcfe
Diff: https://reviews.apache.org/r/31688/diff/
Testing
-------
mvn install
Functional - Passing - new => 3 known test failures: count1.q, count2.q,
joinCSVParquet.q cased by DRILL-2236.
Advanced - TPCH SF100 - Parquet => known failures of 01.q and 10.q
Thanks,
Chris Westin
