----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31871/ -----------------------------------------------------------
Review request for drill and Jacques Nadeau. Bugs: DRILL-2406 https://issues.apache.org/jira/browse/DRILL-2406 Repository: drill-git Description ------- To enable planning rules to take advantage of constant expressions in queries, or to allow them to run queries against small datasets, such as partition information we need to e able to evaluate expressions at planning time. Expression evaluation in the regular expecuation path is relatively expensive, as it invovles java code generation, compilation and JITing expression trees. An interpreted expression system was added recently to allow evaluating an expression without generating java code at runtime. This patch exposes that work (after some refactorings in 2143 and the first part of 2406) to the planning context for use in optimizer rules. Diffs ----- exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillFunctionRegistry.java 00aaec6 exec/java-exec/src/main/java/org/apache/drill/exec/memory/TopLevelAllocator.java 2a28bcb exec/java-exec/src/main/java/org/apache/drill/exec/ops/BufferManager.java PRE-CREATION exec/java-exec/src/main/java/org/apache/drill/exec/ops/FragmentContext.java aa1dffd exec/java-exec/src/main/java/org/apache/drill/exec/ops/QueryContext.java c881432 exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillReduceAggregatesRule.java 93fff35 exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/visitor/InsertLocalExchangeVisitor.java 907fcb1 exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlOperator.java 6b54c43 exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java 409450f Diff: https://reviews.apache.org/r/31871/diff/ Testing ------- Cluster tests completed, waiting on unit tests. Thanks, Jason Altekruse