> On March 10, 2015, 12:20 a.m., Aman Sinha wrote: > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java, > > line 346 > > <https://reviews.apache.org/r/31707/diff/4/?file=888255#file888255line346> > > > > Remove the 'is' in the first sentence.
Error message changed > On March 10, 2015, 12:20 a.m., Aman Sinha wrote: > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java, > > line 371 > > <https://reviews.apache.org/r/31707/diff/4/?file=888255#file888255line371> > > > > Same as above. Error message changed > On March 10, 2015, 12:20 a.m., Aman Sinha wrote: > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java, > > line 423 > > <https://reviews.apache.org/r/31707/diff/4/?file=888255#file888255line423> > > > > Miss-match should have one 's' Error message changed > On March 10, 2015, 12:20 a.m., Aman Sinha wrote: > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java, > > line 453 > > <https://reviews.apache.org/r/31707/diff/4/?file=888255#file888255line453> > > > > Why did you remove the super.cleanup() call ? I did not remove it. Actually, the line you were referring to is at "the inner class", which is used by the Top-Level Class to do clean up. The cleanup() method of the top-level class still does call super.cleanup(). > On March 10, 2015, 12:20 a.m., Aman Sinha wrote: > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/PreProcessLogicalRel.java, > > line 150 > > <https://reviews.apache.org/r/31707/diff/4/?file=888259#file888259line150> > > > > I think referencing the 2207 JIRA is misleading here because that one > > will be marked Fixed once this feature goes in. To avoid confusion, this > > should either refer to a specific star column bug or not reference the jira. Agree. The new error message directs users to DRILL-2414, which is specific to this exception. > On March 10, 2015, 12:20 a.m., Aman Sinha wrote: > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java, > > line 471 > > <https://reviews.apache.org/r/31707/diff/4/?file=888255#file888255line471> > > > > This error looks different from what we throw for IterOutcome.NONE in > > other operators...can you check and make this consistent. Changed to throw new IllegalStateException(String.format("Unknown state %s.", upstream)); - Sean Hsuan-Yi ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31707/#review75808 ----------------------------------------------------------- On March 10, 2015, 1:14 a.m., Sean Hsuan-Yi Chu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31707/ > ----------------------------------------------------------- > > (Updated March 10, 2015, 1:14 a.m.) > > > Review request for drill, Aman Sinha and Jinfeng Ni. > > > Bugs: DRILL-2207 > https://issues.apache.org/jira/browse/DRILL-2207 > > > Repository: drill-git > > > Description > ------- > > DRILL-2207: New Union-All Implementation > > > Diffs > ----- > > > exec/java-exec/src/main/java/org/apache/drill/exec/expr/ExpressionTreeMaterializer.java > 3565bf4 > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java > 99aec92 > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAller.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllerTemplate.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillRelOptUtil.java > 270462b > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/PreProcessLogicalRel.java > 4c9d301 > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/visitor/FinalColumnReorderer.java > 60a9e4b > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/UnsupportedOperatorsVisitor.java > dcd5ebf > > exec/java-exec/src/main/java/org/apache/drill/exec/record/VectorContainer.java > baf74b1 > > exec/java-exec/src/main/java/org/apache/drill/exec/resolver/TypeCastRules.java > f5b0de4 > exec/java-exec/src/test/java/org/apache/drill/TestExampleQueries.java > 225b21e > exec/java-exec/src/test/java/org/apache/drill/TestUnionAll.java 36b062b > exec/java-exec/src/test/resources/store/text/data/t.json PRE-CREATION > > exec/java-exec/src/test/resources/testframework/testExampleQueries/testAggregationOnUnionAllOperator/q1.tsv > PRE-CREATION > > exec/java-exec/src/test/resources/testframework/testExampleQueries/testAggregationOnUnionAllOperator/q2.tsv > PRE-CREATION > exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q1.tsv > PRE-CREATION > exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q10.tsv > PRE-CREATION > exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q11.tsv > PRE-CREATION > exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q12.tsv > PRE-CREATION > exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q13.tsv > PRE-CREATION > exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q14.tsv > PRE-CREATION > exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q15.tsv > PRE-CREATION > exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q16.tsv > PRE-CREATION > exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q17.tsv > PRE-CREATION > exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q2.tsv > PRE-CREATION > exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q3.tsv > PRE-CREATION > exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q4.tsv > PRE-CREATION > exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q5.tsv > PRE-CREATION > exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q6.tsv > PRE-CREATION > > exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q6_1.tsv > PRE-CREATION > exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q7.tsv > PRE-CREATION > exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q8.tsv > PRE-CREATION > exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q9.tsv > PRE-CREATION > > Diff: https://reviews.apache.org/r/31707/diff/ > > > Testing > ------- > > Design Doc can be found from: > https://issues.apache.org/jira/browse/DRILL-2207 > > Unit, Customers, TPCH passed > waiting for Functional... > > > Thanks, > > Sean Hsuan-Yi Chu > >
