----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31876/#review76017 -----------------------------------------------------------
contrib/native/client/src/clientlib/drillClient.cpp <https://reviews.apache.org/r/31876/#comment123405> If your intention is to set the applications' pointer to null, then you must pass the address of the pointer. void DrillClient::freeRecordBatch(RecordBatch** ppRecordBatch){ delete *ppRecordBatch; *ppRecordBatch=NULL; } contrib/native/client/src/include/drill/drillClient.hpp <https://reviews.apache.org/r/31876/#comment123406> This is required on Windows but not on Linux. Can you add a link to the explanation? - Parth Chandra On March 10, 2015, 8:44 p.m., Alexander zarei wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31876/ > ----------------------------------------------------------- > > (Updated March 10, 2015, 8:44 p.m.) > > > Review request for drill, Norris Lee, Parth Chandra, and Xiao Meng. > > > Repository: drill-git > > > Description > ------- > > DRILL-2415: Export Drill C++ Client symbols so as to provide dynamic linking > > > Diffs > ----- > > contrib/native/client/src/clientlib/drillClient.cpp 878dad4 > contrib/native/client/src/include/drill/drillClient.hpp 19fec69 > contrib/native/client/src/include/drill/recordBatch.hpp 4abc2de > > Diff: https://reviews.apache.org/r/31876/diff/ > > > Testing > ------- > > Built and tested on Windows Win32/x64, Linux x86/x8664 and Mac OS X Darwin > Universal platforms; > > Tested by query submitter with > > ./querySubmitter query='SELECT * FROM `hive43`.`default`.`orders` limit > 5000;SELEct * from INFORMATION_SCHEMA.SCHEMATA' type=sql > connectStr=local=192.168.39.44:31010 api=async logLevel=fatal > test.txt > > (please note that for Windows double quotations needed e.g. "select * ...") > > and comparing the result files with the previous version of C++ client; > > Also thoroughly tested by automated and manual testing of Drill ODBC driver. > > Thanks, > Alex > > > Thanks, > > Alexander zarei > >
