----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32087/#review76798 -----------------------------------------------------------
Ship it! One minor comment, +1 otherwise common/src/main/java/org/apache/drill/common/types/Types.java <https://reviews.apache.org/r/32087/#comment124457> Instead of the TODO can we just fix it. Seems like this method is used only in a single place so the change should be trivial. - Mehant Baid On March 15, 2015, 9:11 p.m., Daniel Barclay wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32087/ > ----------------------------------------------------------- > > (Updated March 15, 2015, 9:11 p.m.) > > > Review request for drill, menangkihugyWS melandkihugyWS and Parth Chandra. > > > Repository: drill-git > > > Description > ------- > > Fixed mapping from TypeProtos.MinorType.VARCHAR to java.sql.Types.NVARCHAR > to be to java.sql.Types.VARCHAR. > > > Diffs > ----- > > common/src/main/java/org/apache/drill/common/types/Types.java 04fec54 > > Diff: https://reviews.apache.org/r/32087/diff/ > > > Testing > ------- > > Ran new tests for JDBC metadata fixes (DRILL-2420--related) and existing > tests. > > > Thanks, > > Daniel Barclay > >
