----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32354/#review77472 -----------------------------------------------------------
Ship it! Can you please add a unit test. Looks good otherwise exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/CompoundIdentifierConverter.java <https://reviews.apache.org/r/32354/#comment125560> four data fields - Mehant Baid On March 21, 2015, 1:05 a.m., Sean Hsuan-Yi Chu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32354/ > ----------------------------------------------------------- > > (Updated March 21, 2015, 1:05 a.m.) > > > Review request for drill and Mehant Baid. > > > Bugs: DRILL-2094 > https://issues.apache.org/jira/browse/DRILL-2094 > > > Repository: drill-git > > > Description > ------- > > Add SqlOrderBy rule for CompoundIdentifierConverter > > > Diffs > ----- > > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/CompoundIdentifierConverter.java > 061524d > > Diff: https://reviews.apache.org/r/32354/diff/ > > > Testing > ------- > > unit, > fucntional (except 28 expected plan failures in the partition_pruning suite), > tpch > > all passed > > > Thanks, > > Sean Hsuan-Yi Chu > >
