----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32335/#review77515 -----------------------------------------------------------
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/AbstractContainerVector.java <https://reviews.apache.org/r/32335/#comment125608> the two if conditions are the same? we should combine them. Could you also provide little more detail as to what is happening here and why we need this? - Mehant Baid On March 20, 2015, 10:46 p.m., Hanifi Gunes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32335/ > ----------------------------------------------------------- > > (Updated March 20, 2015, 10:46 p.m.) > > > Review request for drill and Mehant Baid. > > > Repository: drill-git > > > Description > ------- > > The changes cover > - Fix schema path materialization for complex types. > - Add unit tests > > > Diffs > ----- > > > exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/AbstractContainerVector.java > 3bc7d11b9d7bf7f3159041ac2235333519d17931 > > exec/java-exec/src/test/java/org/apache/drill/exec/expr/TestSchemaPathMaterialization.java > PRE-CREATION > exec/java-exec/src/test/resources/complex/json/repeated_list.json > PRE-CREATION > exec/java-exec/src/test/resources/complex/json/repeated_list_map.json > PRE-CREATION > > Diff: https://reviews.apache.org/r/32335/diff/ > > > Testing > ------- > > unit + regression > > > Thanks, > > Hanifi Gunes > >
