----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32590/#review78163 -----------------------------------------------------------
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java <https://reviews.apache.org/r/32590/#comment126651> This does not look right...the check here is checking schema change status of the outgoing batch of UnionAll, wherease you are interested in the incoming batch. exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java <https://reviews.apache.org/r/32590/#comment126652> Same as above. exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java <https://reviews.apache.org/r/32590/#comment126653> The error message says 'right input' - it should be 'left input' - Aman Sinha On March 27, 2015, 8:33 p.m., Sean Hsuan-Yi Chu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32590/ > ----------------------------------------------------------- > > (Updated March 27, 2015, 8:33 p.m.) > > > Review request for drill and Aman Sinha. > > > Bugs: DRILL-2591.1 > https://issues.apache.org/jira/browse/DRILL-2591.1 > > > Repository: drill-git > > > Description > ------- > > DRILL-2591: In UnionAllRecordBactch, the mechansim to detect schema change is > corrected > > > Diffs > ----- > > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java > 806104a > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/visitor/FinalColumnReorderer.java > 1aa033b > exec/java-exec/src/test/java/org/apache/drill/TestUnionAll.java 520c204 > exec/java-exec/src/test/resources/store/json/dateData.json PRE-CREATION > exec/java-exec/src/test/resources/store/json/timeStmpData.json PRE-CREATION > exec/java-exec/src/test/resources/testframework/testUnionAllQueries/q18.tsv > PRE-CREATION > > Diff: https://reviews.apache.org/r/32590/diff/ > > > Testing > ------- > > QA, unit all passed > > > Thanks, > > Sean Hsuan-Yi Chu > >
