----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32640/#review78289 -----------------------------------------------------------
contrib/native/client/src/clientlib/drillClientImpl.cpp <https://reviews.apache.org/r/32640/#comment126828> missing delete qr contrib/native/client/src/clientlib/drillClientImpl.cpp <https://reviews.apache.org/r/32640/#comment126816> Remove? Since it'll always be false - Norris Lee On March 30, 2015, 9:10 p.m., Parth Chandra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32640/ > ----------------------------------------------------------- > > (Updated March 30, 2015, 9:10 p.m.) > > > Review request for drill, Alexander zarei, Mehant Baid, Norris Lee, and Xiao > Meng. > > > Repository: drill-git > > > Description > ------- > > The original QueryResult message has been split into two parts, QueryResult > which will carry only status information and QueryData which will contain the > actual data. > As a part of this change, the server will no longer send back a last_chunk > flag with the record batches. The server will guarantee sending back a > 'terminal' state message which would be either QUERY_COMPLETED, QUERY_FAILE, > or QUERY_CANCELED. > To manage this more cleanly, the C++ api no longer maintains a list of > cancelled queries. Instead, if a QueryData message for a cancelled query is > received, the API simply discards the message. If a QueryResult message for a > cancelled query is received the state is updated and the API stops listening > for more messages. > > > Diffs > ----- > > contrib/native/client/example/querySubmitter.cpp bef64bf > contrib/native/client/src/clientlib/drillClientImpl.hpp 33f81db > contrib/native/client/src/clientlib/drillClientImpl.cpp 71f960e > contrib/native/client/src/clientlib/recordBatch.cpp 44140b2 > contrib/native/client/src/include/drill/common.hpp 6560692 > contrib/native/client/src/include/drill/recordBatch.hpp 92a4c3ad > contrib/native/client/src/protobuf/BitData.pb.h f1f9353 > contrib/native/client/src/protobuf/BitData.pb.cc ef4f99d > contrib/native/client/src/protobuf/User.pb.h eca199d > contrib/native/client/src/protobuf/User.pb.cc d85c81b > contrib/native/client/src/protobuf/UserBitShared.pb.h bbf3fdc > contrib/native/client/src/protobuf/UserBitShared.pb.cc 7c237f6 > > Diff: https://reviews.apache.org/r/32640/diff/ > > > Testing > ------- > > Mac, Win64, Linux 64(with Valgrind) for both sync and async APIs. Incuded > queries that had errors, multiple queries in parallel and multiple queries in > parallel with errors and cancellations. > > > Thanks, > > Parth Chandra > >
