----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32819/ -----------------------------------------------------------
(Updated April 3, 2015, 4:57 p.m.) Review request for drill, Jacques Nadeau and Parth Chandra. Changes ------- Uploading the actual patch. Bugs: DRILL-2673 https://issues.apache.org/jira/browse/DRILL-2673 Repository: drill-git Description ------- Please see DRILL-2673 for details Diffs (updated) ----- exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java 6d4c86c exec/java-exec/src/main/java/org/apache/drill/exec/rpc/AbstractHandshakeHandler.java 9048241 exec/java-exec/src/main/java/org/apache/drill/exec/rpc/BasicServer.java 0e0398d exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserClient.java 925154d exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserRpcConfig.java 908d304 exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserServer.java c76d324 protocol/src/main/java/org/apache/drill/exec/proto/SchemaUserProtos.java 3b056cf protocol/src/main/java/org/apache/drill/exec/proto/UserProtos.java 048bd20 protocol/src/main/java/org/apache/drill/exec/proto/beans/BitToUserHandshake.java 813eb1c protocol/src/main/java/org/apache/drill/exec/proto/beans/HandshakeStatus.java PRE-CREATION protocol/src/main/protobuf/User.proto 6c41a37 Diff: https://reviews.apache.org/r/32819/diff/ Testing ------- Existing unittests pass. Negative tests which involve handshake request result in error are not available in this patch, because the only case where we could introduce the failure is when the RPC version mismatch happens which is same for both UserClient and UserServer in tests. Patch for DRILL-2674 includes negative tests where user authentication fails in handshake processing in UserServer. Thanks, Venki Korukanti