----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32494/#review79105 -----------------------------------------------------------
Ship it! Sqlline does not seem to be an issue. - Parth Chandra On March 31, 2015, 9:32 p.m., Daniel Barclay wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32494/ > ----------------------------------------------------------- > > (Updated March 31, 2015, 9:32 p.m.) > > > Review request for drill, Mehant Baid and Parth Chandra. > > > Bugs: DRILL-2565 > https://issues.apache.org/jira/browse/DRILL-2565 > > > Repository: drill-git > > > Description > ------- > > - Created AlreadyClosedSqlException. > - (Moved JdbcApiSqlException to be subclass of SQLNonTransientException.) > - Created test Drill2489CallsAfterCloseThrowExceptionsTest for eventual > fixing of DRILL-2489. > - (Is partial: Covers Connection, Statement, and ResultSet.) > - (Is interim: Most methods' test disabled with @Ignore.) > - Added already-closed checking in key places, especially those that involve > communication and could hang for a while rather than dying quickly (e.g., > Statement.execute...(...)). > > > Diffs > ----- > > > exec/jdbc/src/main/java/org/apache/drill/jdbc/AlreadyClosedSqlException.java > PRE-CREATION > exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillConnectionImpl.java > e590778 > exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillDatabaseMetaData.java > ca1648d > exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillResultSet.java 0ce33f4 > exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillStatement.java d934c7c > > exec/jdbc/src/main/java/org/apache/drill/jdbc/InvalidCursorStateSqlException.java > 7b04371 > exec/jdbc/src/main/java/org/apache/drill/jdbc/JdbcApiSqlException.java > d6b05fb > > exec/jdbc/src/test/java/org/apache/drill/jdbc/test/Drill2489CallsAfterCloseThrowExceptionsTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/32494/diff/ > > > Testing > ------- > > Ran new specific tests. > > Run existing tests; no new problems. > > > Thanks, > > Daniel Barclay > >
