----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32404/#review79818 -----------------------------------------------------------
exec/java-exec/src/main/java/org/apache/drill/exec/exception/AuthorizationException.java <https://reviews.apache.org/r/32404/#comment129411> does it make sense to include structured storage of the username that was attempting access? exec/java-exec/src/main/java/org/apache/drill/exec/ops/ViewExpansionContext.java <https://reviews.apache.org/r/32404/#comment129413> Can you add a much larger description about the concept of tokens and how they work here? exec/java-exec/src/main/java/org/apache/drill/exec/ops/ViewExpansionContext.java <https://reviews.apache.org/r/32404/#comment129412> Shouldn't this be an authorization exception? exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/AbstractBase.java <https://reviews.apache.org/r/32404/#comment129414> As discussed, let's make this part of constructor and immutable. Then only use in GroupScan and null elsewhere. exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ImplCreator.java <https://reviews.apache.org/r/32404/#comment129415> Is this expensive? If so, maybe we should cache? - Jacques Nadeau On April 7, 2015, 5:41 p.m., Venki Korukanti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32404/ > ----------------------------------------------------------- > > (Updated April 7, 2015, 5:41 p.m.) > > > Review request for drill and Jacques Nadeau. > > > Repository: drill-git > > > Description > ------- > > Please see JIRA DRILL-2514 for details. > > > Diffs > ----- > > > contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBaseGroupScan.java > 6d18d12 > > contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBasePushFilterIntoScan.java > 2b419d4 > > contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBaseSchemaFactory.java > 7a0a64b > > contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBaseStoragePlugin.java > c10b0ab > > contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBaseSubScan.java > 23d8c5a > > contrib/storage-hive/core/src/main/java/org/apache/drill/exec/planner/sql/logical/HivePushPartitionFilterIntoScan.java > 374c486 > > contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveScan.java > b96fda4 > > contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveStoragePlugin.java > f4baf3b > > contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveSubScan.java > 1233202 > > contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/schema/HiveSchemaFactory.java > 0e16e6f > > contrib/storage-mongo/src/main/java/org/apache/drill/exec/store/mongo/MongoGroupScan.java > f6b449b > > contrib/storage-mongo/src/main/java/org/apache/drill/exec/store/mongo/MongoPushDownFilterForScan.java > 9af49b1 > > contrib/storage-mongo/src/main/java/org/apache/drill/exec/store/mongo/MongoStoragePlugin.java > e46d8ec > > contrib/storage-mongo/src/main/java/org/apache/drill/exec/store/mongo/MongoSubScan.java > 36008cf > > contrib/storage-mongo/src/main/java/org/apache/drill/exec/store/mongo/schema/MongoSchemaFactory.java > a227c9a > distribution/src/resources/drill-override-example.conf 943d644 > exec/java-exec/pom.xml 7c08534 > exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java > bd93206 > > exec/java-exec/src/main/java/org/apache/drill/exec/dotdrill/DotDrillFile.java > f9a8ff5 > > exec/java-exec/src/main/java/org/apache/drill/exec/exception/AuthorizationException.java > PRE-CREATION > exec/java-exec/src/main/java/org/apache/drill/exec/ops/FragmentContext.java > 18b93e9 > exec/java-exec/src/main/java/org/apache/drill/exec/ops/QueryContext.java > 2fa0b18 > > exec/java-exec/src/main/java/org/apache/drill/exec/ops/ViewExpansionContext.java > PRE-CREATION > exec/java-exec/src/main/java/org/apache/drill/exec/opt/BasicOptimizer.java > b1a71a5 > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/AbstractBase.java > defb4e4 > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/PhysicalOperator.java > a5518ca > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ImplCreator.java > e25f1c0 > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillTable.java > c8f872e > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillViewTable.java > 68e666a > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DynamicDrillTable.java > 843db58 > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/CreateTableHandler.java > 300d65d > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/torel/ConversionContext.java > a486369 > > exec/java-exec/src/main/java/org/apache/drill/exec/server/options/SystemOptionManager.java > 1a8559e > > exec/java-exec/src/main/java/org/apache/drill/exec/store/AbstractStoragePlugin.java > b032fce > exec/java-exec/src/main/java/org/apache/drill/exec/store/SchemaConfig.java > PRE-CREATION > exec/java-exec/src/main/java/org/apache/drill/exec/store/SchemaFactory.java > feadabd > exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePlugin.java > ef5978c > > exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginRegistry.java > 5d0eed6 > > exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FileSystemPlugin.java > c5ca41b > > exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FileSystemSchemaFactory.java > 44132d0 > > exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FormatPlugin.java > 58d5b42 > > exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/WorkspaceSchemaFactory.java > 45e9129 > > exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/easy/EasyFormatPlugin.java > 6e1e0cc > > exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/easy/EasyGroupScan.java > 54cad56 > > exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/easy/EasySubScan.java > e78ba0b > > exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/text/TextFormatPlugin.java > bf46395 > > exec/java-exec/src/main/java/org/apache/drill/exec/store/ischema/InfoSchemaStoragePlugin.java > 77c6b9a > > exec/java-exec/src/main/java/org/apache/drill/exec/store/ischema/RecordGenerator.java > 947998d > > exec/java-exec/src/main/java/org/apache/drill/exec/store/mock/MockStorageEngine.java > 51b2208 > > exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetFormatPlugin.java > e204a2c > > exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java > acac61f > > exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetRowGroupScan.java > fd40f41 > > exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetScanBatchCreator.java > c1f815e > > exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/SystemTablePlugin.java > 13e0ff6 > > exec/java-exec/src/main/java/org/apache/drill/exec/util/ImpersonationUtil.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java > 23ef0d3 > > exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/FragmentExecutor.java > a7e6c46 > exec/java-exec/src/main/resources/drill-module.conf 6bd8db0 > exec/java-exec/src/test/java/org/apache/drill/BaseTestQuery.java 725594a > exec/java-exec/src/test/java/org/apache/drill/PlanningBase.java 264123f > > exec/java-exec/src/test/java/org/apache/drill/exec/impersonation/BaseTestImpersonation.java > PRE-CREATION > > exec/java-exec/src/test/java/org/apache/drill/exec/impersonation/TestImpersonationMetadata.java > PRE-CREATION > > exec/java-exec/src/test/java/org/apache/drill/exec/impersonation/TestImpersonationQueries.java > PRE-CREATION > > exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TestOptiqPlans.java > ba905c4 > pom.xml 5e4bc68 > > Diff: https://reviews.apache.org/r/32404/diff/ > > > Testing > ------- > > Manually tested. Unittests with MiniDFS are coming in next patch. > > > Thanks, > > Venki Korukanti > >
