-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33897/
-----------------------------------------------------------

(Updated May 6, 2015, 9:44 p.m.)


Review request for drill and Jason Altekruse.


Changes
-------

fixed patch: contained 2 separate commits
rebased on top of master


Bugs: DRILL-2602
    https://issues.apache.org/jira/browse/DRILL-2602


Repository: drill-git


Description
-------

updated both ExternalSortBatch and StreamAggBatch to throw a proper UNSUPPORTED 
user exception.
Here is the output when using a Stream aggregate:
```
Query failed: UNSUPPORTED_OPERATION ERROR: Sort doesn't currently support sorts 
with changing schemas

Fragment 0:0

[Error Id: 43fea1a6-1ae2-4c17-970e-8e168e347241 on 172.30.1.91:31010]
```
And here is the error message for a hash aggregate:
```
Query failed: UNSUPPORTED_OPERATION ERROR: Hash aggregate does not support 
schema changes

Fragment 0:0

[Error Id: 6f849343-0a9d-4681-b101-17d7e1e32917 on 172.30.1.91:31010]
```


Diffs (updated)
-----

  
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggBatch.java
 b753574 
  
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/ExternalSortBatch.java
 e88bc67 
  
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/SingleBatchSorterTemplate.java
 75892f9 

Diff: https://reviews.apache.org/r/33897/diff/


Testing (updated)
-------

pending results of unit/regression tests


Thanks,

abdelhakim deneche

Reply via email to