-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33779/
-----------------------------------------------------------
(Updated May 6, 2015, 10:20 p.m.)
Review request for drill, abdelhakim deneche, Mehant Baid, and Parth Chandra.
Changes
-------
Rebased (re accidental removal of System.out.println in 2884(?) patch).
Bugs: DRILL-2932
https://issues.apache.org/jira/browse/DRILL-2932
Repository: drill-git
Description
-------
DRILL-2932: Fix: Error reported via System.out rather than exception message
Main:
- Removed the System.out.println(...) from submissionFailed(...).
- Put UserException's message text in SQLException's message (didn't just wrap).
- Added undoing of extra wrapping by AvaticaStatement.execute...(...).
- Created unit test for execute...(...) exceptions.
- Refined related exception handling (handled cases separately, narrowed throws
declarations and catches).
JDBC cleanup:
- Renamed ex -> executionFailureException
- Added getNext() method doc. comment.
- Removed some obsolete alignment spaces.
Added "review this" TODOs re DRILL-2933 (probably-obsolete
SchemaChangeException):
- DrillCursor;
- MergingRecordBatch, ParquetResultListener, PrintingResultsListener,
QueryWrapper, RecordBatchLoader, UnorderedReceiverBatch;
- TestDrillbitResilience, TestTextColumn, BaseTestQuery, DrillTestWrapper.
Diffs (updated)
-----
exec/java-exec/src/main/java/org/apache/drill/exec/client/PrintingResultsListener.java
64e7266
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/mergereceiver/MergingRecordBatch.java
c36b0d3
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unorderedreceiver/UnorderedReceiverBatch.java
09cb7ad
exec/java-exec/src/main/java/org/apache/drill/exec/record/RecordBatchLoader.java
088630c
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/QueryResultHandler.java
3beae89
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/QueryWrapper.java
aa43aa9
exec/java-exec/src/test/java/org/apache/drill/BaseTestQuery.java d6e6d08
exec/java-exec/src/test/java/org/apache/drill/DrillTestWrapper.java 856dfa5
exec/java-exec/src/test/java/org/apache/drill/exec/server/TestDrillbitResilience.java
2698701
exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/ParquetResultListener.java
0e80f91
exec/java-exec/src/test/java/org/apache/drill/exec/store/text/TestTextColumn.java
3c1a38a
exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillCursor.java 6bad3ce
exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillStatement.java 7fc79be
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java
a7cc0c1
exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestExecutionExceptionsToClient.java
PRE-CREATION
Diff: https://reviews.apache.org/r/33779/diff/
Testing
-------
Ran SQLLine to confirm change from System.out plus poor SQLException to good
SQLException.
Ran new specific unit test.
Ran regular tests; no new failures.
Thanks,
Daniel Barclay
