----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34008/ -----------------------------------------------------------
(Updated May 12, 2015, 12:32 a.m.) Review request for drill, abdelhakim deneche, Jacques Nadeau, and Venki Korukanti. Changes ------- Addressed review comments Repository: drill-git Description ------- [DRILL-2977](https://issues.apache.org/jira/browse/DRILL-2977), [DRILL-2978](https://issues.apache.org/jira/browse/DRILL-2978): Swap fragment execution methods and cancellation changes Execution: In WorkManager, + swap implementations of startFragmentPendingRemote() and addFragmentRunner() + warn if there are running fragments in close() Cancellation: + for fragments waiting on data, delegate cancellations to WorkEventBus (in Foreman and ControlMessageHandler) + documentation Diffs (updated) ----- exec/java-exec/src/main/java/org/apache/drill/exec/rpc/control/WorkEventBus.java d90096a exec/java-exec/src/main/java/org/apache/drill/exec/work/WorkManager.java 1d3a0b0 exec/java-exec/src/main/java/org/apache/drill/exec/work/batch/ControlMessageHandler.java d12e6d5 exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/QueryManager.java 090a377 exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/RootFragmentManager.java 67ef9b8 Diff: https://reviews.apache.org/r/34008/diff/ Testing ------- Passes all unit tests and regression tests. Thanks, Sudheesh Katkam
