----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34074/#review83357 -----------------------------------------------------------
Ship it (non-binding) - Chris Westin On May 11, 2015, 10:35 p.m., Sudheesh Katkam wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34074/ > ----------------------------------------------------------- > > (Updated May 11, 2015, 10:35 p.m.) > > > Review request for drill, Chris Westin and Venki Korukanti. > > > Repository: drill-git > > > Description > ------- > > [DRILL-3035](https://issues.apache.org/jira/browse/DRILL-3035): Created > ControlsInjector interface to enforce method implementations > + Fixes potential NPEs from site classes that use injectInterruptiblePause > > > Diffs > ----- > > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScanBatch.java > 6176f77 > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScreenCreator.java > 76dc91c > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/mergereceiver/MergingRecordBatch.java > 5d990f0 > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/partitionsender/PartitionerDecorator.java > c355070 > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unorderedreceiver/UnorderedReceiverBatch.java > e40fe54 > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlWorker.java > 6961ee6 > > exec/java-exec/src/main/java/org/apache/drill/exec/store/pojo/PojoRecordReader.java > a893da1 > > exec/java-exec/src/main/java/org/apache/drill/exec/testing/ControlsInjector.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/testing/ExecutionControlsInjector.java > 387d300 > > exec/java-exec/src/main/java/org/apache/drill/exec/testing/NoOpControlsInjector.java > bb13d1f > > exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java > bf62ccb > > exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/FragmentExecutor.java > d96e6d6 > > exec/java-exec/src/test/java/org/apache/drill/exec/testing/TestCountDownLatchInjection.java > c98f54c > > exec/java-exec/src/test/java/org/apache/drill/exec/testing/TestExceptionInjection.java > e3558a1 > > exec/java-exec/src/test/java/org/apache/drill/exec/testing/TestPauseInjection.java > ba29c58 > > Diff: https://reviews.apache.org/r/34074/diff/ > > > Testing > ------- > > Passes regression and unit tests. > > > Thanks, > > Sudheesh Katkam > >
