----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34071/#review83408 -----------------------------------------------------------
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/BasicServer.java <https://reviews.apache.org/r/34071/#comment134392> build() already logs user exceptions at INFO level. Are you sure you want to log the same exception twice ? exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillConnectionImpl.java <https://reviews.apache.org/r/34071/#comment134393> this will alter the user exception's message. Sometimes this will clutter the original error message making it less useful to the user - abdelhakim deneche On May 12, 2015, 5:59 a.m., Daniel Barclay wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34071/ > ----------------------------------------------------------- > > (Updated May 12, 2015, 5:59 a.m.) > > > Review request for drill, abdelhakim deneche, Mehant Baid, and Parth Chandra. > > > Bugs: DRILL-3034 > https://issues.apache.org/jira/browse/DRILL-3034 > > > Repository: drill-git > > > Description > ------- > > Applied UserException to can't-bind-to-port error. [BasicServer] > Added specific handling of UserException (above case or other) in > SQLException wrapping. [DrillConnectionImpl] > > > Diffs > ----- > > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/BasicServer.java > a148436 > exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillConnectionImpl.java > 30279e6 > > Diff: https://reviews.apache.org/r/34071/diff/ > > > Testing > ------- > > Manually tested in SQLLine and debugger. > > Ran regular tests; no new failures. > > > Thanks, > > Daniel Barclay > >
