> On May 14, 2015, 10:59 p.m., Sudheesh Katkam wrote: > > exec/java-exec/src/test/java/org/apache/drill/exec/server/TestDrillbitResilience.java, > > line 803 > > <https://reviews.apache.org/r/34184/diff/2/?file=960663#file960663line803> > > > > Please rename this method so others don't use this to test a query, as > > the name suggests. Maybe testExternalSort(...)
That makes sense. BTW, I dropped this method in the new patch because of the potential misleading there. - Sean Hsuan-Yi ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34184/#review83865 ----------------------------------------------------------- On May 14, 2015, 11:14 p.m., Sean Hsuan-Yi Chu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34184/ > ----------------------------------------------------------- > > (Updated May 14, 2015, 11:14 p.m.) > > > Review request for drill, abdelhakim deneche, Jinfeng Ni, and Steven Phillips. > > > Bugs: DRILL-3065 > https://issues.apache.org/jira/browse/DRILL-3065 > > > Repository: drill-git > > > Description > ------- > > Clean the SelectionVector4 in mSort after failure happens > > > Diffs > ----- > > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/ExternalSortBatch.java > 529a6ca > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/MSortTemplate.java > 9acae9e > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/MSorter.java > d97ffc0 > > exec/java-exec/src/test/java/org/apache/drill/exec/server/TestDrillbitResilience.java > f95fbe1 > > Diff: https://reviews.apache.org/r/34184/diff/ > > > Testing > ------- > > Unit test passed; Others are running > > > Thanks, > > Sean Hsuan-Yi Chu > >
