> On May 14, 2015, 5:33 p.m., abdelhakim deneche wrote: > > exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/FragmentExecutor.java, > > line 230 > > <https://reviews.apache.org/r/34245/diff/1/?file=960805#file960805line230> > > > > if we return here, this fragment will never send it's final state to > > the Foreman
We've already marked the context as failed. Won't notifying the Foreman get taken care of in the finally clause below (the return is in the try)? It seemed to work when we tested this as the fix for a memory leak. - Chris ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34245/#review83879 ----------------------------------------------------------- On May 14, 2015, 5:10 p.m., Chris Westin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34245/ > ----------------------------------------------------------- > > (Updated May 14, 2015, 5:10 p.m.) > > > Review request for drill and Jacques Nadeau. > > > Bugs: DRILL-3063 > https://issues.apache.org/jira/browse/DRILL-3063 > > > Repository: drill-git > > > Description > ------- > > Changed the cleanup handling at the end of ImplCreator.getExec(), and > handle the newly returned null value in FragmentExecutor.run(). > > > Diffs > ----- > > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ImplCreator.java > 77ca0f5 > > exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/FragmentExecutor.java > 8c49d68 > > Diff: https://reviews.apache.org/r/34245/diff/ > > > Testing > ------- > > tests are running.... > > > Thanks, > > Chris Westin > >
