----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34297/ -----------------------------------------------------------
(Updated May 15, 2015, 6 p.m.) Review request for drill and Jacques Nadeau. Changes ------- WriteActivityHandler.write() change to use ChannelHandlerContext.write() for forward its message along the handler chain; this shouldn't make a difference over using super., because the default implementation of ChannelOutboundHandlerAdapter is supposedly already doing that, but it is the recommended thing to do according to http://netty.io/4.0/api/io/netty/channel/ChannelPipeline.html . More significantly, to combat our concern that the write activity handler might not be called when we want it to, changed it's pipeline add to addFirst() (instead of addLast()). Since it forwards it's calls, that should be harmless, but ensures that it gets called even if some other upstream handler handles the event and doesn't forward it. Bugs: DRILL-3103 https://issues.apache.org/jira/browse/DRILL-3103 Repository: drill-git Description ------- Modified BasicServer so that it also bumps an activity counter for writes as well as reads when figuring out when to time out. Diffs (updated) ----- exec/java-exec/src/main/java/org/apache/drill/exec/rpc/BasicServer.java 5c04264 Diff: https://reviews.apache.org/r/34297/diff/ Testing ------- mvn install passed presubmit suite running.... Thanks, Chris Westin
