----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34374/ -----------------------------------------------------------
Review request for drill and Steven Phillips. Bugs: DRILL-3133 https://issues.apache.org/jira/browse/DRILL-3133 Repository: drill-git Description ------- MergingRecordBatch stores batches in an array list before loading them with RecordBatchLoader. If the query is canceled before all received batches are loaded, some of the batches won't be cleaned up. lines 307 and 339 contain questions to the reviewers. I will update the patch accordingly Diffs ----- exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/mergereceiver/MergingRecordBatch.java baf9bda Diff: https://reviews.apache.org/r/34374/diff/ Testing ------- unit test and tpch100 are passing Thanks, abdelhakim deneche