----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34575/#review84843 -----------------------------------------------------------
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/fn/JsonReader.java <https://reviews.apache.org/r/34575/#comment136253> The JIRA talks about performance degradation - is that as a result of this fix or regardless of this fix ? exec/java-exec/src/test/java/org/apache/drill/TestInListConstructedByUnionAll.java <https://reviews.apache.org/r/34575/#comment136254> Do you need this test in a separate file ? why not add it to the existing TestLargeInClause ? - Aman Sinha On May 21, 2015, 11:36 p.m., Sean Hsuan-Yi Chu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34575/ > ----------------------------------------------------------- > > (Updated May 21, 2015, 11:36 p.m.) > > > Review request for drill, Aman Sinha and Jinfeng Ni. > > > Bugs: DRILL-3019 > https://issues.apache.org/jira/browse/DRILL-3019 > > > Repository: drill-git > > > Description > ------- > > In JsonReader, update atLeastOneWrite to true if writeListDataIfTyped and > writeMapDataIfTyped write a value > > > Diffs > ----- > > > exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/fn/JsonReader.java > 095d8c6 > > exec/java-exec/src/test/java/org/apache/drill/TestInListConstructedByUnionAll.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/34575/diff/ > > > Testing > ------- > > Unit, TPCH done > > waiting for functional... > > > Thanks, > > Sean Hsuan-Yi Chu > >
