----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34530/#review84962 -----------------------------------------------------------
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillPushProjectPastUnionRule.java <https://reviews.apache.org/r/34530/#comment136420> With this new rule, what will happen if we are projecting an expression after a UNION-ALL ? for example: SELECT 2 * y FROM (SELECT n_nationkey y FROM nation UNION ALL SELECT n_regionkey y FROM nation ) - Aman Sinha On May 21, 2015, 6:12 a.m., Sean Hsuan-Yi Chu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34530/ > ----------------------------------------------------------- > > (Updated May 21, 2015, 6:12 a.m.) > > > Review request for drill, Aman Sinha and Jinfeng Ni. > > > Bugs: DRILL-3130 > https://issues.apache.org/jira/browse/DRILL-3130 > > > Repository: drill-git > > > Description > ------- > > Add DrillPushProjectPastUnionRule to push project below union > > > Diffs > ----- > > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillPushProjectPastUnionRule.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillRuleSets.java > f7cfbf4 > exec/java-exec/src/test/java/org/apache/drill/TestUnionAll.java 5f98d90 > > exec/java-exec/src/test/resources/testframework/testUnionAllQueries/testProjectFiltertPushDownOverUnionAll.tsv > PRE-CREATION > > exec/java-exec/src/test/resources/testframework/testUnionAllQueries/testProjectPushDownOverUnionAllWithProject.tsv > PRE-CREATION > > exec/java-exec/src/test/resources/testframework/testUnionAllQueries/testProjectPushDownOverUnionAllWithoutProject.tsv > PRE-CREATION > > Diff: https://reviews.apache.org/r/34530/diff/ > > > Testing > ------- > > Unit,, TPCH, (waiting for functional) > > > Thanks, > > Sean Hsuan-Yi Chu > >
