----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35393/ -----------------------------------------------------------
Review request for drill and Aman Sinha. Bugs: DRILL-3220 https://issues.apache.org/jira/browse/DRILL-3220 Repository: drill-git Description ------- Made changes to DrillWindowRule and WindowPrel to properly handle constants in OVER clause Diffs ----- exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillWindowRule.java 76939d9 exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/WindowPrel.java 4f6551a exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/window/TestWindowFrame.java 4295002 exec/java-exec/src/test/resources/window/q1.sql PRE-CREATION exec/java-exec/src/test/resources/window/q2.sql PRE-CREATION exec/java-exec/src/test/resources/window/q3218.sql PRE-CREATION exec/java-exec/src/test/resources/window/q3220.sql PRE-CREATION Diff: https://reviews.apache.org/r/35393/diff/ Testing ------- Thanks, abdelhakim deneche