----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35329/ -----------------------------------------------------------
(Updated June 15, 2015, 11:12 p.m.) Review request for drill, Mehant Baid and Parth Chandra. Changes ------- addressed the feedback. remove unused import. refact a test case to use a field instance. Repository: drill-git Description ------- DRILL-2997: Remove references to groupCount from SerializedField - Remove references to group count where applicable and adapt vectors to work with the changes. - Fix misc test cases RepeatedValueVectors - get rid of multiple #load methods and rely on load(metadata, buffer) regardless of the vector type. BaseValueVector - all vector must have a field VariableLengthVectors - all vector must have a field so does offsets vector MapVector - refactor #load for better code readability and consistency RepeatedFixedWidthVectorLike & RepeatedVariableWidthVectorLike - #load is un-needed now Diffs (updated) ----- exec/java-exec/src/main/codegen/templates/RepeatedValueVectors.java 12dce2596a7d590d2d33c85fca5c47acb2495a25 exec/java-exec/src/main/codegen/templates/VariableLengthVectors.java bd41e10d3f69e13d0f8c426460af5e9a09d93fd9 exec/java-exec/src/main/java/org/apache/drill/exec/record/RecordBatchLoader.java de6f66598927bee5fe3afb1d1046cc20c136b424 exec/java-exec/src/main/java/org/apache/drill/exec/vector/BaseValueVector.java ec409a3fc59616708226aa500ccab1680cd261f6 exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/AbstractMapVector.java af364bd5487eb510b2ffc8219a37611b828136e5 exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/BaseRepeatedValueVector.java f292e4c22f07a65036dbdae2cbe809e00758faf6 exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/MapVector.java d0f38c2a397aac7eaad247c39b4b856c89c970a0 exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/RepeatedFixedWidthVectorLike.java fb7ed2a975e095b1f49d3a24cd735b8c7551c7f1 exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/RepeatedListVector.java f6d3d88ca32a6a3320ec317dbe99c0031f0d54c6 exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/RepeatedMapVector.java 4617ede4aaaebe36dbe9f50dccbff107351dc40f exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/RepeatedVariableWidthVectorLike.java c57143e24e2c60ba400c4f3fcfb9c012e5e25a89 exec/java-exec/src/test/java/org/apache/drill/exec/expr/ExpressionTest.java 239a099e66a0a93ce5b517f67b6b20bb5d4b906a exec/java-exec/src/test/java/org/apache/drill/exec/vector/complex/TestEmptyPopulation.java 06a73e22b981d5b8ae7289c171afa703eab91788 exec/java-exec/src/test/java/org/apache/drill/exec/vector/complex/fn/TestJsonReaderWithSparseFiles.java 544b962142e24f6c185ad91384d6cb270776acb3 protocol/src/main/java/org/apache/drill/exec/proto/SchemaUserBitShared.java bee2a3dfac6325460e9902d901b72a6c72cb7d81 protocol/src/main/java/org/apache/drill/exec/proto/UserBitShared.java 92afa4f4b6fc223fb9179887d808c3f2925f303b protocol/src/main/java/org/apache/drill/exec/proto/beans/SerializedField.java 699097a0ab45468b90ec8f5141108c844dbfadf1 protocol/src/main/protobuf/UserBitShared.proto 68c8612dadfc5cbe4a8157ec516ddf7246f5b956 Diff: https://reviews.apache.org/r/35329/diff/ Testing ------- unit + regression Thanks, Hanifi Gunes