> On June 17, 2015, 5:40 p.m., Venki Korukanti wrote: > > LGTM. Couple of things to mention: > > 1. With this change, some Hive UDFs which expect smallint or tinyint input > > type couldn't be resolved. > > 2. A Hive UDF can output TINYINT or SMALLINT which is again introduced into > > Drill. > > This should be ok as there may not be many Hive UDFs expecting or outputing > > these types (couldn't find any in built-in UDFs) > > Jacques Nadeau wrote: > We should get these limitations incorporated into the documentation. > Jason, can you work with Bridget and Kristine to add this.
Will do - Jason ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35475/#review88243 ----------------------------------------------------------- On June 15, 2015, 9:58 p.m., Jason Altekruse wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35475/ > ----------------------------------------------------------- > > (Updated June 15, 2015, 9:58 p.m.) > > > Review request for drill, Mehant Baid and Venki Korukanti. > > > Bugs: DRILL-3263 > https://issues.apache.org/jira/browse/DRILL-3263 > > > Repository: drill-git > > > Description > ------- > > Smallint and tinyint hve been disabled in much of Drill as they were only > partly implemented. Drill-2470 has been opened to track the completion of the > tinyint and smallint types. Untill this task is complete this change will > enable a wider range of queries to work with standard sql functions and > Drill's implicit cast system. The change is pretty small, it just changes the > type exposed from Hive tables with columns of smallint or tinyint to be a > regular integer. > > > Diffs > ----- > > > contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveFieldConverter.java > 658dd79 > > contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveRecordReader.java > 3c8b9ba > > contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/schema/DrillHiveTable.java > 0da28e0 > > contrib/storage-hive/core/src/test/java/org/apache/drill/exec/fn/hive/HiveTestUDFImpls.java > 31e4715 > > contrib/storage-hive/core/src/test/java/org/apache/drill/exec/fn/hive/TestSampleHiveUDFs.java > 86a78e5 > > contrib/storage-hive/core/src/test/java/org/apache/drill/exec/hive/TestHiveStorage.java > 27ba9fe > > Diff: https://reviews.apache.org/r/35475/diff/ > > > Testing > ------- > > Unit tests passing, cluster tests are pending > > > Thanks, > > Jason Altekruse > >
