----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35573/#review88285 -----------------------------------------------------------
Ship it! Ship it once comments are addressed. exec/java-exec/src/main/codegen/templates/TypeHelper.java (line 471) <https://reviews.apache.org/r/35573/#comment140728> Would you use buildErrMsg here as well? exec/java-exec/src/main/codegen/templates/TypeHelper.java (line 494) <https://reviews.apache.org/r/35573/#comment140729> as well as all others that follow - Hanifi Gunes On June 17, 2015, 8:30 p.m., abdelhakim deneche wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35573/ > ----------------------------------------------------------- > > (Updated June 17, 2015, 8:30 p.m.) > > > Review request for drill and Hanifi Gunes. > > > Bugs: DRILL-3304 > https://issues.apache.org/jira/browse/DRILL-3304 > > > Repository: drill-git > > > Description > ------- > > Made some changes to TypeHelper template to display the failed "operation" > and minor-type + data-mode when an UnsupportedOperationException is thrown > > > Diffs > ----- > > common/src/main/java/org/apache/drill/common/exceptions/ErrorHelper.java > 5dd9b67 > exec/java-exec/src/main/codegen/templates/TypeHelper.java ad818bd > > Diff: https://reviews.apache.org/r/35573/diff/ > > > Testing > ------- > > all unit tests are passing along with functional/tpch100 > > > Thanks, > > abdelhakim deneche > >