----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35413/#review88298 -----------------------------------------------------------
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillCursor.java (line 167) <https://reviews.apache.org/r/35413/#comment140745> to answer your question in the comment: *Exceptions in the server can cause the server to return to the client a record batch that has inconsistent data, particularly the record batch may have a row count set but no data.* (DRILL-3241) - abdelhakim deneche On June 17, 2015, 5:06 p.m., Daniel Barclay wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35413/ > ----------------------------------------------------------- > > (Updated June 17, 2015, 5:06 p.m.) > > > Review request for drill and abdelhakim deneche. > > > Bugs: DRILL-3285 > https://issues.apache.org/jira/browse/DRILL-3285 > > > Repository: drill-git > > > Description > ------- > > Added/edited comments: > - field doc. comments > - method doc. comments > - branch/block comments > > Removed unused recordBatchCount and getRecordBatchCount(). > > Added logger call for spurious batch. > > Various cleanup: > - Cleaned up logger. > - Added "final" on updateColumns(). > - Wrapped some lines > - Misc. comment whitespace. > > > Diffs > ----- > > exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillCursor.java > PRE-CREATION > exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java > cb6bd1d > > Diff: https://reviews.apache.org/r/35413/diff/ > > > Testing > ------- > > Ran tests (all parts together); no new errors. > > > Thanks, > > Daniel Barclay > >
