----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35414/#review88302 -----------------------------------------------------------
+1 (non-binding) - abdelhakim deneche On June 17, 2015, 5:06 p.m., Daniel Barclay wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35414/ > ----------------------------------------------------------- > > (Updated June 17, 2015, 5:06 p.m.) > > > Review request for drill and abdelhakim deneche. > > > Bugs: DRILL-3285 > https://issues.apache.org/jira/browse/DRILL-3285 > > > Repository: drill-git > > > Description > ------- > > Renamed state/control-flow members: > - started -> initialSchemaLoaded > - first -> beforeFirstBatch > - redoFirstNext -> returnTrueForNextCallToNext > - finished -> afterLastRow > > Renamed other items: > - changed -> schemaChanged > - currentBatch -> currentBatchHolder > - DrillResultSet's currentBatch -> batchLoader > > > Diffs > ----- > > exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillCursor.java > PRE-CREATION > exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java > cb6bd1d > > Diff: https://reviews.apache.org/r/35414/diff/ > > > Testing > ------- > > Ran tests (all parts together); no new errors. > > > Thanks, > > Daniel Barclay > >
