----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35417/#review88306 -----------------------------------------------------------
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillCursor.java (line 244) <https://reviews.apache.org/r/35417/#comment140748> should this read "loadInitialSchema() called a second time" ? exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillCursor.java (line 246) <https://reviews.apache.org/r/35417/#comment140749> please add messages to the assertions, otherwise we'll get an empty AssertionError message in the logs exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillCursor.java (line 270) <https://reviews.apache.org/r/35417/#comment140750> same here - abdelhakim deneche On June 17, 2015, 5:06 p.m., Daniel Barclay wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35417/ > ----------------------------------------------------------- > > (Updated June 17, 2015, 5:06 p.m.) > > > Review request for drill and abdelhakim deneche. > > > Bugs: DRILL-3285 > https://issues.apache.org/jira/browse/DRILL-3285 > > > Repository: drill-git > > > Description > ------- > > Split the original public next() method (which was hacked to handle an extra, > initial call to read the schema batch) into: > - new loadInitialSchema() (for handling the call for the schema) > - modified next() (for handling normal calls from ResultSet.next()) > - new private nextRowInternally() (for common code) > > Pulled invariant afterFirstBatch up out of bogus-batch loop. > > > Diffs > ----- > > exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillCursor.java > PRE-CREATION > exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java > cb6bd1d > > Diff: https://reviews.apache.org/r/35417/diff/ > > > Testing > ------- > > Ran tests (all parts together); no new errors. > > > Thanks, > > Daniel Barclay > >
