> On July 1, 2015, 9:26 p.m., Jacques Nadeau wrote:
> > exec/java-exec/src/test/java/org/apache/drill/exec/memory/TestAllocators.java,
> > line 153
> > <https://reviews.apache.org/r/36103/diff/1/?file=997594#file997594line153>
> >
> > Shouldn't we make sure we actually got the exception since we expect it?
if no exception is thrown the unit test will fail, because of the fail("...")
inside the try block. Do I need to do something more ?
- abdelhakim
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36103/#review90134
-----------------------------------------------------------
On July 1, 2015, 9:21 p.m., abdelhakim deneche wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36103/
> -----------------------------------------------------------
>
> (Updated July 1, 2015, 9:21 p.m.)
>
>
> Review request for drill, Chris Westin and Hanifi Gunes.
>
>
> Bugs: DRILL-3445
> https://issues.apache.org/jira/browse/DRILL-3445
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> BufferAllocator.buffer(int) implementations throw an
> OutOfMemoryRuntimeException instead of returning null.
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/codegen/templates/FixedValueVectors.java 7103a17
> exec/java-exec/src/main/codegen/templates/VariableLengthVectors.java
> 50ae770
>
> exec/java-exec/src/main/java/org/apache/drill/exec/cache/VectorAccessibleSerializable.java
> 016cd92
>
> exec/java-exec/src/main/java/org/apache/drill/exec/memory/BufferAllocator.java
> 811cceb
>
> exec/java-exec/src/main/java/org/apache/drill/exec/memory/TopLevelAllocator.java
> b4386a4
>
> exec/java-exec/src/main/java/org/apache/drill/exec/record/selection/SelectionVector2.java
> 7a7c012
>
> exec/java-exec/src/main/java/org/apache/drill/exec/rpc/ProtobufLengthDecoder.java
> 4e03f11
>
> exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetDirectByteBufferAllocator.java
> cf30db6
> exec/java-exec/src/main/java/org/apache/drill/exec/vector/BitVector.java
> 10bdf07
> exec/java-exec/src/main/java/parquet/hadoop/ColumnChunkIncReadStore.java
> 6337d4c
> exec/java-exec/src/test/java/org/apache/drill/TestAllocationException.java
> 051ad4e
>
> exec/java-exec/src/test/java/org/apache/drill/exec/memory/TestAllocators.java
> 74ce225
>
> Diff: https://reviews.apache.org/r/36103/diff/
>
>
> Testing
> -------
>
> unit tests are passing, along with functional and tpch100
>
>
> Thanks,
>
> abdelhakim deneche
>
>
