----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36208/#review90518 -----------------------------------------------------------
exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/QueryManager.java (line 431) <https://reviews.apache.org/r/36208/#comment143636> It may be just a personal opinion, and you may safely ignore this comment, but shouldn't nodeDead() return true when it does it's job (marking running fragments as completed) and false otherwise ? exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/QueryManager.java (line 518) <https://reviews.apache.org/r/36208/#comment143637> alreadyCompleted is not used anywhere, you should just call #nodeDead() inside the if exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/QueryManager.java (line 534) <https://reviews.apache.org/r/36208/#comment143638> you should probably include your fix for DRILL-3448 as part of this patch, it's 3 lines change - abdelhakim deneche On July 6, 2015, 5:10 p.m., Sudheesh Katkam wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36208/ > ----------------------------------------------------------- > > (Updated July 6, 2015, 5:10 p.m.) > > > Review request for drill, abdelhakim deneche and Jacques Nadeau. > > > Bugs: DRILL-3455 > https://issues.apache.org/jira/browse/DRILL-3455 > > > Repository: drill-git > > > Description > ------- > > DRILL-3455: If fragments on unregistered Drillbits finished successfully, do > not fail the query > > > Diffs > ----- > > > exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/QueryManager.java > 9318233 > > Diff: https://reviews.apache.org/r/36208/diff/ > > > Testing > ------- > > will update > > > Thanks, > > Sudheesh Katkam > >
