> On July 6, 2015, 9:02 p.m., abdelhakim deneche wrote: > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/WindowPrel.java, > > line 127 > > <https://reviews.apache.org/r/36219/diff/1/?file=1000449#file1000449line127> > > > > when we reach the else-block it means i >= fn.size() which means > > indexInConstants >= 0 > > > > You should remove (indexInConstants >= 0) from the else condition as it > > is always true
Make sense. Will address in the new patch - Sean Hsuan-Yi ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36219/#review90564 ----------------------------------------------------------- On July 6, 2015, 8:33 p.m., Sean Hsuan-Yi Chu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36219/ > ----------------------------------------------------------- > > (Updated July 6, 2015, 8:33 p.m.) > > > Review request for drill, abdelhakim deneche and Aman Sinha. > > > Bugs: DRILL-3292 > https://issues.apache.org/jira/browse/DRILL-3292 > > > Repository: drill-git > > > Description > ------- > > At the stage of converting Prel to Pop (planning phase), ensure constants in > Window are converted to LogicalExpression > > > Diffs > ----- > > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/WindowPrel.java > 170438e > exec/java-exec/src/test/java/org/apache/drill/exec/TestWindowFunctions.java > 8676c28 > > Diff: https://reviews.apache.org/r/36219/diff/ > > > Testing > ------- > > unit, tpch, functional > > > Thanks, > > Sean Hsuan-Yi Chu > >
