----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29278/#review91945 -----------------------------------------------------------
LGTM! common/src/main/java/org/apache/drill/common/expression/package-info.java (line 22) <https://reviews.apache.org/r/29278/#comment145710> conditions, as well as common/src/main/java/org/apache/drill/common/expression/package-info.java (line 24) <https://reviews.apache.org/r/29278/#comment145711> logically as ASTs common/src/main/java/org/apache/drill/common/logical/FormatPluginConfig.java (line 27) <https://reviews.apache.org/r/29278/#comment145713> such formats like as? - Sudheesh Katkam On Jan. 27, 2015, 1:36 a.m., Jason Altekruse wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29278/ > ----------------------------------------------------------- > > (Updated Jan. 27, 2015, 1:36 a.m.) > > > Review request for drill, Daniel Barclay and Jacques Nadeau. > > > Bugs: Drill-1904 > https://issues.apache.org/jira/browse/Drill-1904 > > > Repository: drill-git > > > Description > ------- > > Add package level documentation to the sources of Drill > > > Diffs > ----- > > common/src/main/java/org/apache/drill/common/config/package-info.java > PRE-CREATION > common/src/main/java/org/apache/drill/common/exceptions/package-info.java > PRE-CREATION > > common/src/main/java/org/apache/drill/common/expression/aggregate/BasicAggregates.java > 5f18aaf > > common/src/main/java/org/apache/drill/common/expression/fn/package-info.java > PRE-CREATION > common/src/main/java/org/apache/drill/common/expression/package-info.java > PRE-CREATION > > common/src/main/java/org/apache/drill/common/expression/types/package-info.java > PRE-CREATION > > common/src/main/java/org/apache/drill/common/expression/visitors/package-info.java > PRE-CREATION > common/src/main/java/org/apache/drill/common/graph/package-info.java > PRE-CREATION > > common/src/main/java/org/apache/drill/common/logical/FormatPluginConfig.java > 936e4f2 > > common/src/main/java/org/apache/drill/common/logical/FormatPluginConfigBase.java > 0704085 > common/src/main/java/org/apache/drill/common/logical/data/package-info.java > PRE-CREATION > > common/src/main/java/org/apache/drill/common/logical/data/visitors/package-info.java > PRE-CREATION > common/src/main/java/org/apache/drill/common/logical/package-info.java > PRE-CREATION > common/src/main/java/org/apache/drill/common/package-info.java PRE-CREATION > common/src/main/java/org/apache/drill/common/types/package-info.java > PRE-CREATION > common/src/main/java/org/apache/drill/common/util/package-info.java > PRE-CREATION > > contrib/storage-mongo/src/main/java/org/apache/drill/exec/store/mongo/package-info.java > PRE-CREATION > exec/java-exec/src/main/java/org/apache/drill/exec/cache/package-info.java > PRE-CREATION > exec/java-exec/src/main/java/org/apache/drill/exec/client/package-info.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/compile/bytecode/package-info.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/compile/package-info.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/compile/sig/package-info.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/coord/local/package-info.java > PRE-CREATION > exec/java-exec/src/main/java/org/apache/drill/exec/coord/package-info.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/coord/zk/package-info.java > PRE-CREATION > exec/java-exec/src/main/java/org/apache/drill/exec/disk/package-info.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/dotdrill/package-info.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/exception/package-info.java > PRE-CREATION > exec/java-exec/src/main/java/org/apache/drill/exec/package-info.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/29278/diff/ > > > Testing > ------- > > Just comments, no code changes > > > Thanks, > > Jason Altekruse > >
