----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36630/#review92444 -----------------------------------------------------------
Ship it! Having the new interface that is implemented by DFS and Parquet pruning (and in future Hive pruning) seems good to me. - Aman Sinha On July 21, 2015, 1:14 a.m., Mehant Baid wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36630/ > ----------------------------------------------------------- > > (Updated July 21, 2015, 1:14 a.m.) > > > Review request for drill and Aman Sinha. > > > Bugs: DRILL-3503 > https://issues.apache.org/jira/browse/DRILL-3503 > > > Repository: drill-git > > > Description > ------- > > Added an interface to abstract away partitioning scheme away from the > partition pruning rule. Removed some of the redundant logic in PruneScanRule. > > > Diffs > ----- > > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/DFSPartitionpruningScheme.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/ParquetPartitionDescriptor.java > 127e70a > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/ParquetPartitionPruningScheme.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/PartitionPruningScheme.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillRuleSets.java > daa7276 > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/partition/ParquetPruneScanRule.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/partition/PruneScanRule.java > 5b5e4bc > > Diff: https://reviews.apache.org/r/36630/diff/ > > > Testing > ------- > > > Thanks, > > Mehant Baid > >
