----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36809/#review93660 -----------------------------------------------------------
contrib/storage-hive/core/src/main/java/org/apache/drill/exec/planner/sql/HivePartitionDescriptor.java (line 104) <https://reviews.apache.org/r/36809/#comment148091> Do you want this to be case-sensitive comparison ? contrib/storage-hive/core/src/main/java/org/apache/drill/exec/planner/sql/HivePartitionLocation.java (line 24) <https://reviews.apache.org/r/36809/#comment148071> Why not use a String array since that's what you are populating it with when you call mostDirs[i].substring. contrib/storage-hive/core/src/main/java/org/apache/drill/exec/planner/sql/HivePartitionLocation.java (line 33) <https://reviews.apache.org/r/36809/#comment148072> This prefix won't work on all supported platforms would it ? Also, could you add javadoc on the type of partition descriptor expected in Hive - i.e 'year=2015'. contrib/storage-hive/core/src/main/java/org/apache/drill/exec/planner/sql/HivePartitionLocation.java (line 38) <https://reviews.apache.org/r/36809/#comment148073> This will throw IOBE if supplied max nesting level is less than mostDirs.length. contrib/storage-hive/core/src/main/java/org/apache/drill/exec/planner/sql/HivePartitionLocation.java (line 43) <https://reviews.apache.org/r/36809/#comment148075> Is the caller ensuring index < partitionValue.length ? Otherwise, add assert.. contrib/storage-hive/core/src/test/java/org/apache/drill/exec/TestHivePartitionPruning.java (line 68) <https://reviews.apache.org/r/36809/#comment148092> Are there any Hive PP unit tests that reference subdirectories ? Would be good to add couple of tests. exec/java-exec/src/main/java/org/apache/drill/exec/planner/ParquetPartitionDescriptor.java (line 89) <https://reviews.apache.org/r/36809/#comment148093> It wasn't clear why the Hive changes affected this.. is this based on a different patch from before ? - Aman Sinha On July 28, 2015, 10:38 p.m., Mehant Baid wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36809/ > ----------------------------------------------------------- > > (Updated July 28, 2015, 10:38 p.m.) > > > Review request for drill and Aman Sinha. > > > Repository: drill-git > > > Description > ------- > > Add support for interpreter based partition pruning for hive tables. Also > removes the old partition pruning logic. > > > Diffs > ----- > > > contrib/storage-hive/core/src/main/java/org/apache/drill/exec/planner/sql/HivePartitionDescriptor.java > 8307dff > > contrib/storage-hive/core/src/main/java/org/apache/drill/exec/planner/sql/HivePartitionLocation.java > PRE-CREATION > > contrib/storage-hive/core/src/main/java/org/apache/drill/exec/planner/sql/logical/HivePushPartitionFilterIntoScan.java > 6ab1a78 > > contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveDataTypeUtility.java > PRE-CREATION > > contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveRecordReader.java > 088fb74 > > contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveStoragePlugin.java > fb827cc > > contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveTable.java > 99101cc > > contrib/storage-hive/core/src/test/java/org/apache/drill/exec/TestHivePartitionPruning.java > c846328 > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/ParquetPartitionDescriptor.java > 127e70a > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DirPathBuilder.java > 892e8cb > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillPushPartitionFilterIntoScan.java > b83cedd > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/PartitionPruningUtil.java > 05ccfb9 > > Diff: https://reviews.apache.org/r/36809/diff/ > > > Testing > ------- > > Pending unit tests. > > > Thanks, > > Mehant Baid > >
