----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37339/#review94923 -----------------------------------------------------------
exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/WindowPrule.java (line 69) <https://reviews.apache.org/r/37339/#comment149636> Since we already maintain a partitionby variable which is set to True only if windowBase.keys.size() > 0, could we leverage that logic and add the Singleton trait based on that variable ? exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/WindowPrule.java (line 71) <https://reviews.apache.org/r/37339/#comment149634> The name distOnAllKeys is misleading since here we are specifying a SINGLETON trait which does not have any keys. - Aman Sinha On Aug. 11, 2015, 3:45 a.m., Sean Hsuan-Yi Chu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37339/ > ----------------------------------------------------------- > > (Updated Aug. 11, 2015, 3:45 a.m.) > > > Review request for drill and Aman Sinha. > > > Bugs: DRILL-3574 > https://issues.apache.org/jira/browse/DRILL-3574 > > > Repository: drill-git > > > Description > ------- > > For the empty Over-Clause, make DrillDistributionTrait to be as SINGLETON > > > Diffs > ----- > > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/DrillDistributionTrait.java > c1e241d > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/WindowPrule.java > 034fd47 > exec/java-exec/src/test/java/org/apache/drill/exec/TestWindowFunctions.java > ce5a477 > > Diff: https://reviews.apache.org/r/37339/diff/ > > > Testing > ------- > > All required > > > Thanks, > > Sean Hsuan-Yi Chu > >
