> On Aug. 17, 2015, 4:08 p.m., Aman Sinha wrote: > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/WindowPrule.java, > > line 159 > > <https://reviews.apache.org/r/37515/diff/1/?file=1041599#file1041599line159> > > > > Would this work if there was non-window-agg functions present...such as > > RANK() (in combination with window aggs) ?
Rank works too. Also, I modified the unit test to have more general coverage there. - Sean Hsuan-Yi ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37515/#review95592 ----------------------------------------------------------- On Aug. 17, 2015, 4:11 a.m., Sean Hsuan-Yi Chu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37515/ > ----------------------------------------------------------- > > (Updated Aug. 17, 2015, 4:11 a.m.) > > > Review request for drill and Aman Sinha. > > > Bugs: DRILL-3657 > https://issues.apache.org/jira/browse/DRILL-3657 > > > Repository: drill-git > > > Description > ------- > > When constants are referred in Window Prel, ensure the indices are shifted > properly > > > Diffs > ----- > > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/WindowPrule.java > f6d2b67 > exec/java-exec/src/test/java/org/apache/drill/exec/TestWindowFunctions.java > 9e09106 > > Diff: https://reviews.apache.org/r/37515/diff/ > > > Testing > ------- > > All required > > > Thanks, > > Sean Hsuan-Yi Chu > >
