Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/98#discussion_r38692395
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/options/FallbackOptionManager.java
---
@@ -35,61 +42,65 @@ public FallbackOptionManager(OptionManager fallback) {
@Override
public Iterator<OptionValue> iterator() {
- return Iterables.concat(fallback, optionIterable()).iterator();
+ return Iterables.concat(fallback, getLocalOptions()).iterator();
}
@Override
- public OptionValue getOption(String name) {
- final OptionValue opt = getLocalOption(name);
- if(opt == null && fallback != null){
+ public OptionValue getOption(final String name) {
+ final OptionValue value = getLocalOption(name);
+ if (value == null && fallback != null) {
--- End diff --
Will add a precondition.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
