----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37910/#review98048 -----------------------------------------------------------
exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java (line 270) <https://reviews.apache.org/r/37910/#comment154259> I didn't add public static final as these are declared in a interface. Valid point about making ExecConstants interface a class and make the constructor private. Please log a JIRA to track it. - Venki Korukanti On Aug. 28, 2015, 4 p.m., Venki Korukanti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37910/ > ----------------------------------------------------------- > > (Updated Aug. 28, 2015, 4 p.m.) > > > Review request for drill and Jason Altekruse. > > > Repository: drill-git > > > Description > ------- > > Please see DRILL-3622 for details. > > > Diffs > ----- > > exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java > 140e9a8 > exec/java-exec/src/main/java/org/apache/drill/exec/ops/QueryContext.java > c3cd4e6 > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/SetOptionHandler.java > 19c9f7f > > exec/java-exec/src/main/java/org/apache/drill/exec/server/options/SystemOptionManager.java > 2d41740 > > exec/java-exec/src/main/java/org/apache/drill/exec/server/options/TypeValidators.java > b8597b7 > > exec/java-exec/src/main/java/org/apache/drill/exec/util/ImpersonationUtil.java > aa766be > exec/java-exec/src/test/java/org/apache/drill/BaseTestQuery.java d428920 > > exec/java-exec/src/test/java/org/apache/drill/exec/rpc/user/security/UserAuthenticatorTestImpl.java > c89471f > > exec/java-exec/src/test/java/org/apache/drill/exec/server/TestOptionsAuthEnabled.java > PRE-CREATION > > exec/java-exec/src/test/java/org/apache/drill/exec/server/rest/RootResource.java > 59adad9 > > Diff: https://reviews.apache.org/r/37910/diff/ > > > Testing > ------- > > Added unittest. Regression suites currently running. > > > Thanks, > > Venki Korukanti > >
