-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37893/
-----------------------------------------------------------
(Updated Sept. 9, 2015, 12:09 a.m.)
Review request for drill, Jacques Nadeau and Mehant Baid.
Changes
-------
Addressed reviewer's comment
Bugs: DRILL-3718
https://issues.apache.org/jira/browse/DRILL-3718
Repository: drill-git
Description
-------
For TSV files, if the TextReader reads a double quote, it would keep scanning
until it gets the second double quote.
However, even getting the second double quote, the current reader will keep
going in order to trim the space (i.e., ' ').
In tsv, there is no need to trim '\t' (tab), which is used to separate fields.
Diffs (updated)
-----
exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/text/compliant/TextReader.java
3899509
exec/java-exec/src/test/java/org/apache/drill/TestExampleQueries.java d15cff2
exec/java-exec/src/test/java/org/apache/drill/exec/store/text/TestNewTextReader.java
e63e528
exec/java-exec/src/test/resources/store/text/WithQuote.tsv PRE-CREATION
exec/java-exec/src/test/resources/store/text/WithQuoteMultiDelimiters.tsv
PRE-CREATION
Diff: https://reviews.apache.org/r/37893/diff/
Testing
-------
All
Thanks,
Sean Hsuan-Yi Chu
