Github user adeneche commented on a diff in the pull request:

    https://github.com/apache/drill/pull/157#discussion_r39442552
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/control/ControlConnection.java
 ---
    @@ -110,7 +110,9 @@ public boolean equals(Object obj) {
     
       public void shutdownIfClient() {
         if (bus.isClient()) {
    -      Closeables.closeQuietly(bus);
    +      try {
    +        Closeables.close(bus, true);
    +      } catch (Exception e) { /* do nothing */ }
    --- End diff --
    
    Any particular reason you added this ? is it safe to just ignore runtime 
exceptions here ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to