----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38359/ -----------------------------------------------------------
(Updated Sept. 15, 2015, 7:57 p.m.) Review request for drill, Jacques Nadeau and Jason Altekruse. Changes ------- Addressed review comments. Repository: drill-git Description ------- Use jetty's SecurityHandler (with FormAuthenticator and LoginService) to enforce authentication. Use jersey's annotations to enforece authorizations. Diffs (updated) ----- distribution/src/resources/drill-override-example.conf 805d6e9 exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java 0f6a5bb exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/DrillRestServer.java 8c14587 exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/DrillRoot.java 3e972b4 exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/LogOutServlet.java PRE-CREATION exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/MetricsResources.java 28a292b exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/QueryResources.java 145a476 exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/QueryWrapper.java ee31929 exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/RestServerHelper.java PRE-CREATION exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/StatusResources.java c99c49b exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/StorageResources.java 49f387c exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/ThreadsResources.java def5acb exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/ViewableWithPermissions.java PRE-CREATION exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/auth/AbstractDrillLoginService.java PRE-CREATION exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/auth/AnonymousAuthenticator.java PRE-CREATION exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/auth/AnonymousLoginService.java PRE-CREATION exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/auth/DrillRestLoginService.java PRE-CREATION exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/auth/DrillUserPrincipal.java PRE-CREATION exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileResources.java 6656bf6 exec/java-exec/src/main/resources/drill-module.conf dbe449a exec/java-exec/src/main/resources/rest/generic.ftl 9df2424 exec/java-exec/src/main/resources/rest/static/img/apache-drill-logo.png PRE-CREATION exec/java-exec/src/main/resources/rest/static/login.html PRE-CREATION Diff: https://reviews.apache.org/r/38359/diff/ Testing ------- Currently testing is manual. Rest based unittests are coming in DRILL-2965. Thanks, Venki Korukanti
